Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
check_duplicate: check name member before using it #70
I tested manually with IPA provider. It works and I was informed about attribute colision:
CI tests passed:
On Tue, Feb 21, 2017 at 01:02:45AM -0800, lslebodn wrote: On (20/02/17 14:43), fidencio wrote: >Can we have this one pushed by @sumit-bose and @jhrozek review? > I would still prefer to see an integration test. Feel free to write one :-)
I tried to, really, but I haven't been able to figure out how to distinguish nicely between a crash and a failure to start. And after about an hour I gave up because there already is a unit test so we won't regress and honestly, I have more pressing work. So unless someone else submits an integration test, I will push this patch before the next upstream release so that we no longer have this bug.