Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIG: validator rules & test #727

Closed
wants to merge 1 commit into from

Conversation

@alexey-tikhonov
Copy link
Member

commented Jan 7, 2019

Add support of 'certmap' config section to validator rules

Resolves:
https://pagure.io/SSSD/sssd/issue/3845

@jhrozek
jhrozek approved these changes Jan 9, 2019
@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Just one nitpick about the commit message: The COMPONENT word in the commit template is a replaceable. So in this case I would use maybe 'CONFIG' in place of the COMPONENT.

But the patch itself is OK, thank you.

@alexey-tikhonov alexey-tikhonov force-pushed the alexey-tikhonov:issue_3845 branch from 9e8fedd to 7d07a73 Jan 9, 2019

CONFIG: validator rules & test
Add support of 'certmap' config section to validator rules

Resolves:
https://pagure.io/SSSD/sssd/issue/3845

@alexey-tikhonov alexey-tikhonov force-pushed the alexey-tikhonov:issue_3845 branch from 7d07a73 to c890d05 Jan 9, 2019

@alexey-tikhonov alexey-tikhonov changed the title COMPONENT: config validator rules & test CONFIG: validator rules & test Jan 9, 2019

@alexey-tikhonov

This comment has been minimized.

Copy link
Member Author

commented Jan 9, 2019

So in this case I would use maybe 'CONFIG' in place of the COMPONENT.

Amended.

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Thank you for your patience with fixing the commit message. ACK.

@jhrozek jhrozek self-assigned this Jan 9, 2019

@jhrozek jhrozek added the Accepted label Jan 9, 2019

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

@jhrozek jhrozek closed this Jan 10, 2019

@jhrozek jhrozek added the Pushed label Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.