Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSSD does not work when no sssd.conf is present #729

Closed
wants to merge 2 commits into from

Conversation

mzidek-gh
Copy link
Contributor

@mzidek-gh mzidek-gh commented Jan 9, 2019

See commit messages for description.

This patch removes the ldif with fallback configuration
and adds the fallback configuration as in-memory
INI snippet.

Fixes:
https://pagure.io/SSSD/sssd/issue/3439
Remove code code that uses libini older then v1

Related:
https://pagure.io/SSSD/sssd/issue/3439
@jhrozek jhrozek self-assigned this Jan 9, 2019
@jhrozek
Copy link
Contributor

jhrozek commented Jan 9, 2019

first thing (not a nack, just an observation) are whitespace errors:

jhrozek@kyubey:~/devel/sssd|review ⇒  git am https://github.com/SSSD/sssd/pull/729
Applying: confdb: Always read snippet files
.git/rebase-apply/patch:175: space before tab in indent.
                                 uint32_t data_len,
.git/rebase-apply/patch:176: space before tab in indent.
                                 struct sss_ini_initdata *init_data)
.git/rebase-apply/patch:199: space before tab in indent.
                                 uint32_t data_len,
.git/rebase-apply/patch:200: space before tab in indent.
                                 struct sss_ini_initdata *init_data);
warning: 4 lines applied after fixing whitespace errors.
Applying: CONFDB: Remove old libini support
.git/rebase-apply/patch:88: space before tab in indent.
                                 uint32_t data_len,
.git/rebase-apply/patch:89: space before tab in indent.
                                 struct sss_ini_initdata *init_data)
warning: 2 lines add whitespace errors.

My git config will fix the errors, but you might want to fix your editor to not include tabs by default in the first place (set expandtab in vim)

@mzidek-gh
Copy link
Contributor Author

Yeah, I edited the file from VM where I do not have my .vimrc installed. Sorry for that.

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well. We need a test, but that can come in a separate PR. I'll add the Accepted label when CI finishes.

@jhrozek
Copy link
Contributor

jhrozek commented Jan 10, 2019

I fixed the whitespace and pushed the commits to master:
b66f8dc
8a3517c

@jhrozek jhrozek closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants