Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confdb: sssd tools don't handle the implicit domain #730

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@thalman
Copy link
Contributor

commented Jan 9, 2019

When no sssd.conf exists, sssctl can not read objects from the cache
This happend because implicit files domain is not taken into
account when creating list of domains. With implicit files domain
it should expand at least to this one domain.

Resolves:
https://pagure.io/SSSD/sssd/issue/3769

@thalman thalman requested review from jhrozek and pbrezina Jan 9, 2019

@thalman

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2019

I believe that it will solve also https://pagure.io/SSSD/sssd/issue/3919, but not tested yet -- there is not clear reproduction procedure for that bug.

@alexey-tikhonov

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

Looks good.
The only remark I have: may be it would make sense to mark confdb_ensure_files_domain() as static since it is not supposed to be used outside of module anymore.

@alexey-tikhonov alexey-tikhonov requested review from alexey-tikhonov and removed request for alexey-tikhonov Jan 18, 2019

confdb: sssd tools don't handle the implicit domain
When no sssd.conf exists, sssctl can not read objects from the cache
This happend because implicit files domain is not taken into
account when creating list of domains. With implicit files domain
it should expand at least to this one domain.

Resolves:
https://pagure.io/SSSD/sssd/issue/3769

@thalman thalman force-pushed the thalman:missing_sssd.conf_issue_3769 branch from 4f09959 to 5897e14 Jan 18, 2019

@thalman

This comment has been minimized.

Copy link
Contributor Author

commented Jan 18, 2019

@alexey-tikhonov thanks for comment. PR updated.

@sumit-bose

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

@alexey-tikhonov, ping, would you like to continue the review or shall I?

@alexey-tikhonov

This comment has been minimized.

Copy link
Member

commented May 17, 2019

@alexey-tikhonov, ping, would you like to continue the review or shall I?

At that moment I was not sure I could ACK the patch, so I provided input I could and didn't assign it to me.
Please, feel free to to review.

@sumit-bose

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Patch looks good and works fine for me. ACK

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

@jhrozek jhrozek closed this May 22, 2019

@jhrozek jhrozek added the Pushed label May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.