Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_provider_be: got rid of went_offline usage #800

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@alexey-tikhonov
Copy link
Member

commented Apr 2, 2019

Got rid of unused anymore went_offline variable

Resolves: https://pagure.io/SSSD/sssd/issue/3991

@thalman
Copy link
Contributor

left a comment

The fix is clear and OK. But I would call that variable simply bool offline. It looks to me more clear what it means than offstatus. I don't push such change, just asking what do you think?

@thalman thalman self-assigned this Apr 3, 2019

data_provider_be: got rid of went_offline usage
Got rid of unused anymore `went_offline` variable

Resolves: https://pagure.io/SSSD/sssd/issue/3991

@alexey-tikhonov alexey-tikhonov force-pushed the alexey-tikhonov:issue_3991 branch from a28133e to 6df559c Apr 4, 2019

@alexey-tikhonov

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

I agree. Patch is amended (and rebased).

@thalman

thalman approved these changes Apr 4, 2019

Copy link
Contributor

left a comment

ACK

@thalman thalman added the Accepted label Apr 4, 2019

@jhrozek

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@jhrozek jhrozek closed this Apr 8, 2019

@jhrozek jhrozek added the Pushed label Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.