Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ New feature - Copy the person’s information to the clipboard #507

Closed
tiagov8 opened this issue Aug 14, 2023 · 17 comments
Closed

✨ New feature - Copy the person’s information to the clipboard #507

tiagov8 opened this issue Aug 14, 2023 · 17 comments
Assignees
@JackDevAU
Labels
feature

Comments

@tiagov8
Copy link
Member

tiagov8 commented Aug 14, 2023

cc @UlyssesMaclaren

Based on email: RE: Initial Meeting - I see a wall of text by Hashem and Uly

Hi team,

Please add another button beside the download button on the SSW people profile pic. It will copy the person’s information to the clipboard into a format as such:

(feel free to tweak this to look better… maybe a square image?)

image
Andrew Harris
Profile: https://www.ssw.com.au/people/andrew-harris
Standard Hourly Rate: $285+GST
Prepaid Hourly Rate: $270+GST (minimum 40 hours per resource, subject to prepaid terms)

A user would then be able to paste this information in a Word document or such.

An example of where the button would ideally go:

image

Figure: Potential ‘copy to clipboard’ button location
@JackDevAU JackDevAU self-assigned this Aug 16, 2023
@JackDevAU
Copy link
Member

JackDevAU commented Aug 16, 2023 •
edited
Loading

Hi @tiagov8,

I've had a bit of a play at getting this to work.

Unfortunately, getting the image + text into 1 clipboard copy & paste is quite difficult.

Here are some options,

✅Option 1. Just text (Recommended)

Just copy the text without the image. Will paste successfully on everything.

image
Figure: Just the text option

❌Option 2. Using a canvas (Not Recommended)

Create a canvas to create a single image that includes the text

image
Figure: Text colour can be anything but went with #cc4141 as it works on white and dark mode

✅Option 3. HTML (Recommended)

Copy HTML + Base64 image to clipboard. Doesn't work on everything. Works well in Outlook.

image
Figure: Output into an email

@UlyssesMaclaren
Copy link

UlyssesMaclaren commented Aug 16, 2023 via email

This was referenced Aug 17, 2023
Merged
Closed
@JackDevAU
Copy link
Member

As per my conversation with @JeanThirion, @UlyssesMaclaren and @PennyWalker. The formatting should be more compact.

From:

image

To:

image

To Myself,

  1. Implement the compact new design

@UlyssesMaclaren
Copy link

UlyssesMaclaren commented Aug 18, 2023 via email

@JackDevAU
Copy link
Member

Small thing… the prepaid rate there is wrong. Should be a $15 discount

Good spot 😅 I'll fix that as well :)

@JeanThirion
Copy link
Member

ONE FULL YEAR after I requested this, it's AWESOME to see it come to life ! Thank you <3

@JackDevAU
Copy link
Member

Done -

I've adjusted the discount to 15 and have changed to the new format.

  1. Please give feedback or react to this message if it is perfect 🚀

image
Figure: New Format pasted into Outlook

@bradystroud
Copy link
Member

@JeanThirion @UlyssesMaclaren @PennyWalker
Tip - you can test it out on staging https://staging.ssw.com.au/people/brady-stroud/

@UlyssesMaclaren
Copy link

UlyssesMaclaren commented Aug 20, 2023 via email

@JeanThirion
Copy link
Member

JeanThirion commented Aug 20, 2023 via email

@tiagov8
Copy link
Member Author

tiagov8 commented Aug 21, 2023

Hey @JackDevAU

The image didn't work for me either... there was a all white image in its place:

Screenshot 2023-08-21 at 11 36 37 AM

Mu suggestion:

  1. Less is more and DRY - Change from:

Brady Stroud

to

BRADY STROUD | https://ssw.com.au/people/brady-stroud
Hourly Rates:

  • Standard: $265+GST
  • Prepaid: $250+GST (minimum 40h, subject to prepaid terms)

@JackDevAU JackDevAU mentioned this issue Aug 23, 2023
Merged
@JackDevAU
Copy link
Member

Hi @JeanThirion, @UlyssesMaclaren, @PennyWalker @tiagov8

A fix has been pushed to staging and is now ready to be tested again 🚀

  1. Please "test please" staging.ssw.com.au/people/brady-stroud

Should get the following:

image
Figure: Brady's info copied into an Outlook email

@UlyssesMaclaren
Copy link

UlyssesMaclaren commented Aug 25, 2023 via email

@PennyWalker
Copy link
Member

PennyWalker commented Aug 25, 2023 via email

@JeanThirion
Copy link
Member

JeanThirion commented Aug 25, 2023 via email

@JackDevAU
Copy link
Member

Done - https://youtu.be/vqgMX13Pk8g

@tiagov8
Copy link
Member Author

tiagov8 commented Jun 12, 2024

Note: A new suggestion was created based on this Issue: https://bettersoftwaresuggestions.com/github/help-me-have-a-clean-message-when-replying-to-an-issue-via-email/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JackDevAU JackDevAU

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tiagov8 @PennyWalker @JeanThirion @bradystroud @UlyssesMaclaren @JackDevAU