Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heise Spout Fixed But How? #517

Closed
ghost opened this issue Apr 25, 2014 · 2 comments
Closed

Heise Spout Fixed But How? #517

ghost opened this issue Apr 25, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 25, 2014

Hi Tobias,
just wanted to leave a quick note because you closed #499 with a notice that the Heise Spout issue was fixed in the latest snapshot.

I had a look at your fix but I'm not sure it does the trick. The issue is with the following line which is not part of your new try construct:

$content = $item->getContent();

This should be inside the try as well because it's the getContent itself that traps when the link can't be fetched!

Just want to make sure it's definitely fixed :-)

Cheers,
Martin

SSilence added a commit that referenced this issue May 2, 2014
@SSilence
Copy link
Member

SSilence commented May 2, 2014

Ah ok, thanks for the note. I thought the sanitize was the problematic instrution.

@SSilence SSilence closed this as completed May 2, 2014
SSilence added a commit that referenced this issue May 2, 2014
@wAmpIre
Copy link

wAmpIre commented Feb 3, 2015

Seems that this is not 100% fixed...

From default.log:

02-03-15 12:23:43 Error file_get_contents(http://www.heise.de/newsticker/meldung/Mac-i-Heft-1-2015-jetzt-im-Handel-2534915.html/from/atom10?wt_mc=rss.ho.beitrag.atom): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants