Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various a11y fixes #1133

Merged
merged 8 commits into from Sep 23, 2019
Merged

Various a11y fixes #1133

merged 8 commits into from Sep 23, 2019

Conversation

@jtojnar
Copy link
Collaborator

jtojnar commented Sep 16, 2019

Closes: #1127, #1132, #1028

jtojnar added 8 commits Sep 16, 2019
This makes selfoss much more navigable using keyboard.

In the future we can disable it in :focus and only apply it in :focus-visible.
It slightly simplifies the code, allows styling expanded items and serves as a step forward in our accessibility.
@jtojnar jtojnar added this to the 2.19 milestone Sep 16, 2019
@jtojnar jtojnar requested a review from niol Sep 16, 2019
@jtojnar

This comment has been minimized.

Copy link
Collaborator Author

jtojnar commented Sep 16, 2019

@niol could you please check, especially the last commit?

@akash07k

This comment has been minimized.

Copy link
Contributor

akash07k commented Sep 17, 2019

Thanks @jtojnar For this.
Please check my other comments on previous issues.
If possible, can we implement pagination for the best user experience and use aria-current on the current page?
This link represents very nice explanations and examples to this:
https://www.a11ymatters.com/pattern/pagination/

@niol
niol approved these changes Sep 23, 2019
@jtojnar jtojnar merged commit 0091b26 into master Sep 23, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jtojnar jtojnar deleted the a11y-fixes branch Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.