Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discarding partially failing amplified test classes #336

Closed
sbihel opened this issue Feb 26, 2018 · 2 comments
Closed

Discarding partially failing amplified test classes #336

sbihel opened this issue Feb 26, 2018 · 2 comments

Comments

@sbihel
Copy link
Contributor

@sbihel sbihel commented Feb 26, 2018

} else if (!result.getFailingTests().isEmpty()) {

This branch is never taken because compileAndRunTests returns null if at least one test is failing.

!result.getFailingTests().isEmpty() ||

@danglotb
Copy link
Member

@danglotb danglotb commented Mar 4, 2018

Hi @sbihel

You would mind to propose a PR that fix this?

Cheers.

@sbihel
Copy link
Contributor Author

@sbihel sbihel commented Mar 5, 2018

Ok!

sbihel pushed a commit to sbihel/dspot that referenced this issue Mar 5, 2018
@danglotb danglotb closed this in f4e45c2 Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants