New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Amplifications location in report #362

Open
sbihel opened this Issue Mar 12, 2018 · 6 comments

Comments

Projects
None yet
2 participants
@sbihel
Copy link
Contributor

sbihel commented Mar 12, 2018

During the amplification process, only the number of a-amplifications and i-amplifications is logged.

Do you think it is possible to also note the location of each amplification?

The location could be the line number, of the path in the AST. But I am not sure if it is possible because multiple rounds of amplifications can occur and we would then need to be able to keep the locations up-to-date.

@danglotb

This comment has been minimized.

Copy link
Member

danglotb commented Mar 12, 2018

Yes, it is possible to track the position of I-amplification / A-amplification.

In DSpot, there this notion of test parent, i.e. the test on which is amplified to obtain new amplified test. The top parent, is the manual - original test. This relationship can be represented by a tree.

If we walk this tree, we can have all the amplifications applied.

I agree that would be great to have such information.

We started to this by adding some comment on the amplified tests. The problem is that the amplified test became unreadable, and so, comments are, by default, disable.

If we put this information into the json, which is possible I think we can completely remove comments.

@sbihel

This comment has been minimized.

Copy link
Contributor Author

sbihel commented Mar 12, 2018

Ok I will work on this

@danglotb

This comment has been minimized.

Copy link
Member

danglotb commented Mar 12, 2018

Okay, Great!

Do not hesitate to ask questions / suggest some stuff. I'll be glad to discuss!

I'm gonna change this issue into a track of your progress on this feature.

Cheers.

@danglotb danglotb added the feature label Mar 12, 2018

@danglotb danglotb changed the title Amplifications location in report Feature: Amplifications location in report Mar 12, 2018

@sbihel sbihel referenced this issue Mar 16, 2018

Closed

Clean amplifier #370

@danglotb

This comment has been minimized.

Copy link
Member

danglotb commented Dec 7, 2018

Hi @sbihel

I think you won't gonna work on this anymore, right? I took the liberty to make it available.

@sbihel

This comment has been minimized.

Copy link
Contributor Author

sbihel commented Dec 8, 2018

Hi @danglotb,

Yes sorry, I should have cleaned my mess 🙇‍♂️

@danglotb

This comment has been minimized.

Copy link
Member

danglotb commented Dec 8, 2018

Hi @sbihel

It is totally fine! I'll just unassign you from this issue to highlight the fact that this is should be done.

I hope you are doing great, and I'll see around!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment