Generated tests with jacoco selector doesn't compile

[vmassol]

command line: java -jar /Users/vmassol/dev/dspot/dspot/target/dspot-1.1.1-SNAPSHOT-jar-with-dependencies.jar --path-to-properties dspot.properties --test-criterion JacocoCoverageSelector --verbose --generate-new-test-class --with-comment

Executed in xwiki-commons/xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-default

Generates a AmplEmbeddableComponentManagerTest test case class which has:

...
    @Test(timeout = 10000)
    public void testLookupThisComponentManager() throws Exception, ComponentLookupException {
        // AssertGenerator add assertion
        Assert.assertNull(((EmbeddableComponentManager) (ecm)).getParent());
        // AssertGenerator add assertion
        Assert.assertNull(((EmbeddableComponentManager) (ecm)).getNamespace());
        // AssertGenerator add assertion
        Assert.assertNull(((EmbeddableComponentManager) (ecm)).getComponentEventManager());
        // AssertGenerator create local variable with return value of invocation
        Object o_testLookupThisComponentManager__3 = new EmbeddableComponentManager().getInstance(ComponentManager.class);
        // AssertGenerator add assertion
        Assert.assertNull(((EmbeddableComponentManager) (o_testLookupThisComponentManager__3)).getParent());
        // AssertGenerator add assertion
        Assert.assertNull(((EmbeddableComponentManager) (o_testLookupThisComponentManager__3)).getNamespace());
        // AssertGenerator add assertion
        Assert.assertNull(((EmbeddableComponentManager) (o_testLookupThisComponentManager__3)).getComponentEventManager());
    }
...

And this doesn't compile (variable "ecm" isn't declared...).

[vmassol]

Missing EmbeddableComponentManager ecm = new EmbeddableComponentManager();.

It seems DSpot moved it below:

Object o_testLookupThisComponentManager__3 = new EmbeddableComponentManager().getInstance(ComponentManager.class);

[vmassol]

Original test:

    @Test
    public void testLookupThisComponentManager() throws ComponentLookupException
    {
        EmbeddableComponentManager ecm = new EmbeddableComponentManager();

        Assert.assertSame(ecm.getInstance(ComponentManager.class), ecm);
    }

[vmassol]

Seems like a pretty important bug.

Also I don't understand how DSpot could have executed this test... It should have failed

[vmassol]

And there are other compile errors such as:

    @Test(timeout = 10000)
    public void testComponentDescriptorInjection() throws Exception {
        EmbeddableComponentManager ecm = new EmbeddableComponentManager();
        // AssertGenerator add assertion
        Assert.assertNull(((EmbeddableComponentManager) (ecm)).getParent());
        // AssertGenerator add assertion
        Assert.assertNull(((EmbeddableComponentManager) (ecm)).getNamespace());
        // AssertGenerator add assertion
        Assert.assertNull(((EmbeddableComponentManager) (ecm)).getComponentEventManager());
        DefaultComponentDescriptor<AmplEmbeddableComponentManagerTest.Role> d = new DefaultComponentDescriptor<>();
        d.setRoleType(AmplEmbeddableComponentManagerTest.Role.class);
        d.setImplementation(AmplEmbeddableComponentManagerTest.ComponentDescriptorRoleImpl.class);
        DefaultComponentDependency dependencyDescriptor = new DefaultComponentDependency();
        dependencyDescriptor.setRoleType(new DefaultParameterizedType(null, ComponentDescriptor.class, AmplEmbeddableComponentManagerTest.ComponentDescriptorRoleImpl.class));
        dependencyDescriptor.setName("descriptor");
        d.addComponentDependency(dependencyDescriptor);
        ecm.registerComponent(d);
        // AssertGenerator add assertion
        Assert.assertFalse(((ComponentDescriptor) (((AmplEmbeddableComponentManagerTest.ComponentDescriptorRoleImpl) (impl)).getComponentDescriptor())).getComponentDependencies().isEmpty());
        // AssertGenerator add assertion
        Assert.assertEquals("org.xwiki.component.embed.AmplEmbeddableComponentManagerTest$Role", ((Type) (((ComponentDescriptor) (((AmplEmbeddableComponentManagerTest.ComponentDescriptorRoleImpl) (impl)).getComponentDescriptor())).getRoleType())).getTypeName());
        // AssertGenerator add assertion
        Assert.assertEquals("default", ((ComponentDescriptor) (((AmplEmbeddableComponentManagerTest.ComponentDescriptorRoleImpl) (impl)).getComponentDescriptor())).getRoleHint());
        ecm.getInstance(AmplEmbeddableComponentManagerTest.Role.class).getComponentDescriptor();
    }

"impl" and "ecm.getInstance(AmplEmbeddableComponentManagerTest.Role.class).getComponentDescriptor();" are not compiling

[danglotb]

Hi, I could reproduce it.

I'm gonna investigate why local variables are removed and why we have

ecm.getInstance(AmplEmbeddableComponentManagerTest.Role.class).getComponentDescriptor()

[danglotb]

The error come from the minimization of DSpot, which aims at reducing the number of statements by removing statements judged useless.

I'm gonna disabled it. I think it is not necessary for now.

[danglotb]

#590 should fix the compilation problems.

After the merge, please pull and retry.

If you are still in trouble, please update me.

@assadOW2 You should also pull and retry, see if your compilation problems are removed.

[vmassol]

It fixes the problem since now with PIT/Descartes I don't get any tests generated at all ;)

[danglotb]

It fixes the problem since now with PIT/Descartes I don't get any tests generated at all ;)

But in this issue, you used JacocoCoverageSelector, isn't?

Did you run DSpot with the PitMutantScoreSelector before the fix and got some amplified test methods, and now you don't?

[vmassol]

But in this issue, you used JacocoCoverageSelector, isn't?

Right, I was retesting with PIT/Descartes since we can't use the JacocoCoverageSelector as it decreases the mutation score (hence the other issue about a combined selector). So right now I'm focusing only on PIT/Descartes but I've noticed yesterday that whenever I used this I don't get any new tests (so far wasn't able to get a single one when I was getting several with PIT/Gregor).

[assadOW2]

@danglotb : I pulled the last version but have build issues, tests don't pass. So for now I am skipping them as you advised me.