Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #336: keep partially failing amplified classes #350

Merged
merged 2 commits into from Mar 5, 2018

Conversation

@sbihel
Copy link
Contributor

sbihel commented Mar 5, 2018

The same 33/37 tests passed so I assume this commit did not break anything.

@danglotb

This comment has been minimized.

Copy link
Member

danglotb commented Mar 5, 2018

The failure come from the check-style
fr/inria/diversify/dspot/Amplification.java:3:8: error: Unused import -com.sun.corba.se.impl.orb.ParserTable.

I know it is not that obvious, I need to find a way to have two different checks 1 for testing and one for checkstyle.

You can fix it easily I think.

@sbihel

This comment has been minimized.

Copy link
Contributor Author

sbihel commented Mar 5, 2018

My bad, didn't pay attention to the ci report

@danglotb danglotb merged commit f4e45c2 into STAMP-project:master Mar 5, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danglotb

This comment has been minimized.

Copy link
Member

danglotb commented Mar 5, 2018

Thank you @sbihel

@sbihel sbihel deleted the sbihel:failed_amp_tests branch Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.