Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation problem by removing specialization of member functions. #42

Merged
merged 1 commit into from Aug 27, 2019

Conversation

@stevenrbrandt
Copy link
Member

commented Aug 27, 2019

Apparently, it's illegal to use template specialization on member functions unless you're using VC++. This PR replaces the template specialization with a simple if/else if routine.

@stevenrbrandt stevenrbrandt requested a review from taless474 Aug 27, 2019

@hkaiser

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

I don't understand the need for this. CircleCI is green and it does use clang for compilation.

@taless474 taless474 merged commit 00c3029 into master Aug 27, 2019

1 check passed

build_and_test Workflow: build_and_test
Details

@taless474 taless474 deleted the fix-quat branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.