Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing reduction of arrays #46

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@hkaiser
Copy link
Member

commented Sep 1, 2019

Fixes #44

@hkaiser hkaiser added the enhancement label Sep 1, 2019
@taless474

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

I get 'data': is not a member of 'blaze::DArrDArrMapExpr<MT1,MT2,OP>'compiling Phylanx's 4d_softmax.

1>c:\repos\blaze_tensor\blaze_tensor\math\expressions\darrreduceexpr.h(963): error C2039: 'data': is not a member of 'blaze::DArrDArrMapExpr<MT1,MT2,OP>'
1>        with
1>        [
1>            MT1=blaze::CustomArray<4,double,true,true,blaze::DynamicArray<4,double>>,
1>            MT2=blaze::CustomArray<4,double,true,true,blaze::DynamicArray<4,double>>,
1>            OP=phylanx::ir::detail::isclose
1>        ]
1>c:\repos\blaze_tensor\blaze_tensor\math\expressions\darrdarrmapexpr.h(932): note: see declaration of 'blaze::DArrDArrMapExpr<MT1,MT2,OP>'
1>        with
1>        [
1>            MT1=blaze::CustomArray<4,double,true,true,blaze::DynamicArray<4,double>>,
1>            MT2=blaze::CustomArray<4,double,true,true,blaze::DynamicArray<4,double>>,
1>            OP=phylanx::ir::detail::isclose
1>        ]
1>c:\repos\blaze_tensor\blaze_tensor\math\expressions\darrreduceexpr.h(1011): note: see reference to function template instantiation 'bool blaze::darrayreduce<blaze::DArrDArrMapExpr<MT1,MT2,OP>,std::logical_and<bool>>(const blaze::DenseArray<blaze::DArrDArrMapExpr<MT1,MT2,OP>> &,std::logical_and<bool>)' being compiled
1>        with
1>        [
1>            MT1=blaze::CustomArray<4,double,true,true,blaze::DynamicArray<4,double>>,
1>            MT2=blaze::CustomArray<4,double,true,true,blaze::DynamicArray<4,double>>,
1>            OP=phylanx::ir::detail::isclose
1>        ]
1>c:\repos\phylanx\src\ir\node_data.cpp(2717): note: see reference to function template instantiation 'bool blaze::reduce<blaze::DArrDArrMapExpr<MT1,MT2,OP>,std::logical_and<bool>>(const blaze::DenseArray<blaze::DArrDArrMapExpr<MT1,MT2,OP>> &,std::logical_and<bool>)' being compiled
1>        with
1>        [
1>            MT1=blaze::CustomArray<4,double,true,true,blaze::DynamicArray<4,double>>,
1>            MT2=blaze::CustomArray<4,double,true,true,blaze::DynamicArray<4,double>>,
1>            OP=phylanx::ir::detail::isclose
1>        ]
1>c:\repos\hpx\libs\parallel_executors\include\hpx\parallel\execution_policy.hpp(648): note: see reference to class template instantiation 'hpx::parallel::execution::parallel_policy_executor<hpx::launch>' being compiled
@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2019

Grrr...

@hkaiser hkaiser force-pushed the fixing_44 branch from 29ce10a to 0a369dc Sep 1, 2019
@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2019

@taless474 Better now?

@taless474

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

Yes, thank you :)

@hkaiser hkaiser merged commit 6c13f33 into master Sep 2, 2019
1 check passed
1 check passed
build_and_test Workflow: build_and_test
Details
@hkaiser hkaiser deleted the fixing_44 branch Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.