New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete quoting for parameters of some CMake commands #1070

Closed
elfring opened this Issue Feb 26, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@elfring
Contributor

elfring commented Feb 26, 2014

Some parameters (like "${hpx_SOURCE_DIR}/cmake" and "${CMAKE_BINARY_DIR}/Release/bin") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like spaces.

I would recommend to apply advices from a Wiki article.

@hkaiser hkaiser added this to the 0.9.8 milestone Feb 26, 2014

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Feb 26, 2014

Member

Do you happen to have a patch available?

Member

hkaiser commented Feb 26, 2014

Do you happen to have a patch available?

@hkaiser hkaiser closed this Mar 25, 2014

@hkaiser hkaiser reopened this Mar 25, 2014

@hkaiser hkaiser modified the milestones: 0.9.9, 0.9.8 Mar 25, 2014

elfring added a commit to elfring/hpx that referenced this issue Apr 2, 2014

Bug #1070: Completed quoting for parameters of some CMake commands
A wiki article pointed out that whitespace will only be preserved for parameters
in CMake commands if passed strings will be appropriately quoted or escaped.
http://cmake.org/Wiki/CMake/Language_Syntax#CMake_splits_arguments_unless_you_use_quotation_marks_or_escapes.

Quoting was added so that more places should also handle file names correctly
which contain space characters or semicolons eventually.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Apr 2, 2014

Member

That's fixed by merging #1104 (dd50c0c)

Member

hkaiser commented Apr 2, 2014

That's fixed by merging #1104 (dd50c0c)

@hkaiser hkaiser closed this Apr 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment