New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoiding collision between winsock2.h and windows.h #1135

Closed
atrantan opened this Issue May 16, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@atrantan
Contributor

atrantan commented May 16, 2014

Collisions occur when we integrate hpx in other project that uses windows.h. This is due to the file hpx_fwd.hpp that includes winsock2.h. To avoid this, the most convenient solution is to create an intermediate header file as described in the link below:
http://www.zachburlingame.com/2011/05/resolving-redefinition-errors-betwen-ws2def-h-and-winsock-h/

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser May 16, 2014

Member

Not sure what we can do about this. Creating an intermediate header file makes only sense if the user includes that file before she include windows.h. That's outside of our control. At the point when hpx_fwd.hpp is included it's already too late to do anything about the problem.

Member

hkaiser commented May 16, 2014

Not sure what we can do about this. Creating an intermediate header file makes only sense if the user includes that file before she include windows.h. That's outside of our control. At the point when hpx_fwd.hpp is included it's already too late to do anything about the problem.

@hkaiser hkaiser added this to the 0.9.9 milestone May 16, 2014

@hkaiser hkaiser self-assigned this May 16, 2014

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser May 19, 2014

Member

This can be closed (the issue will be solved in NT2)

Member

hkaiser commented May 19, 2014

This can be closed (the issue will be solved in NT2)

@hkaiser hkaiser closed this May 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment