New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpx / hpx / config / compiler_specific.hpp #1139

Closed
hadimontakhabi opened this Issue May 28, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@hadimontakhabi

hadimontakhabi commented May 28, 2014

I wonder in the following file,
hpx / hpx / config / compiler_specific.hpp
GNUC__PATCHLEVEL should be changed to GNUC_PATCHLEVEL?

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser May 28, 2014

Member

What is your rationale? Pure esthetics?

Member

hkaiser commented May 28, 2014

What is your rationale? Pure esthetics?

@hadimontakhabi

This comment has been minimized.

Show comment
Hide comment
@hadimontakhabi

hadimontakhabi May 28, 2014

Well, if we are using the predefined macro, as it is defined here:
https://gcc.gnu.org/onlinedocs/gcc-4.9.0/cpp/Common-Predefined-Macros.html
then that is the right macro to use. Otherwise, the macro that we are using now is not defined anywhere!

hadimontakhabi commented May 28, 2014

Well, if we are using the predefined macro, as it is defined here:
https://gcc.gnu.org/onlinedocs/gcc-4.9.0/cpp/Common-Predefined-Macros.html
then that is the right macro to use. Otherwise, the macro that we are using now is not defined anywhere!

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser May 28, 2014

Member

Ahh, excellent catch! thanks!

Member

hkaiser commented May 28, 2014

Ahh, excellent catch! thanks!

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser May 28, 2014

Member

Fixed by d8679d3

Member

hkaiser commented May 28, 2014

Fixed by d8679d3

@hkaiser hkaiser closed this May 28, 2014

@hkaiser hkaiser added this to the 0.9.9 milestone May 28, 2014

@hkaiser hkaiser self-assigned this May 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment