Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Do not put -DNDEBUG into hpx_application.pc #1160
HPX should not put -DNDEBUG into its hpx_application.pc. The choice of using -DNDEBUG or not should belong to the application, not a library (HPX) that an application uses. It is often very convenient to be able to use assert() to track down bugs, even in production code. -DNDEBUG prevents this, forcing people to roll their own assert statement.
Since HPX already uses HPX_ASSERT, why does it care about -DNDEBUG? This seems like an overzealous optimization to me; HPX_DISABLE_ASSERTS should suffice.