Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel::copy_if is broken #1220

Closed
hkaiser opened this issue Aug 11, 2014 · 7 comments

Comments

Projects
None yet
2 participants
@hkaiser
Copy link
Member

commented Aug 11, 2014

The current implementation of parallel::copy_if is broken as it does not properly account for elements not to be copied in the middle of the input sequence. The current test is broken as well as it does not detect this issue.

@hkaiser hkaiser added this to the 0.9.9 milestone Aug 11, 2014

@hkaiser hkaiser self-assigned this Aug 11, 2014

@hkaiser hkaiser modified the milestones: 0.9.10, 0.9.9 Sep 13, 2014

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2014

This is related to #1141 and needs to be fixed before that one can be closed.

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Oct 13, 2014

@Syntaf, what's the status here?

@Syntaf

This comment has been minimized.

Copy link
Member

commented Oct 13, 2014

@hkaiser Sorry, I've been out of the loop for quite some time.

Last I worked on it there were compilation errors related to using msvc11 instead of 12, so I needed to get vs2013 and rebuild boost with the patch that will allow 155 to work with msvc12. I just rebuilt boost 155 to work with VS a couple days ago and should be able to continue working on getting the code to compile. I'll make sure to make some significant progress on copy_if by the end of the week

@Syntaf

This comment has been minimized.

Copy link
Member

commented Oct 25, 2014

I've updated branch N4071 with the current progress I am at with copy_if, but I've hit a wall and do not know how to progress past a certain error.

I feel it has to do with the type of the arguments being passed into hpx::unwrapped, but I am not familiar with unwrapped so am lost at this point.

The error tells me that:
Error 1 error C2039: 'type' : is not a member of 'hpx::util::detail::unwrapped_impl<hpx::parallel::v1::detail::copy_if_helper::<lambda_b6d97a1ea91226a66df27872543578de>>::result<hpx::util::detail::unwrapped_impl<hpx::parallel::v1::detail::copy_if_helper::<lambda_b6d97a1ea91226a66df27872543578de>> (std::vector<hpx::lcos::future<void>,std::allocator<_Ty>>)>' c:\local\boost_1_55_0\boost\utility\enable_if.hpp 40 1 copyif_test_exe

I believe the source of this error is on line 358 but am not completely sure.
full error log

any help would be greatly appreciated

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2014

@Syntaf I'll have a look

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2015

@dcbdan: adding you to this ticket

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Feb 27, 2015

This has been fixed by merging #1385

@hkaiser hkaiser closed this Feb 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.