Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions thrown during parcel handling are not handled correctly #1325

Closed
sithhell opened this issue Dec 8, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@sithhell
Copy link
Member

commented Dec 8, 2014

Currently, exceptions thrown during sending a parcel (put_parcel) or receiving is not properly propagated to the user code. This might lead to non obvious hangs in the user code and prohibits proper fault handling in the network layer.

@hkaiser

This comment has been minimized.

Copy link
Member

commented Dec 8, 2014

We need to fix this in two places:

  • During the bootstrap phase, all exceptions should call hpx::terminate
  • For hpx::apply (which currently stores all caught exceptions in the parcel handler) we should add the ability to register a global exception handler. By default this exception handler should either do nothing (in which case the next call into the parcel handler re-throws the exception; current behavior), or call hpx::terminate as well.

@hkaiser hkaiser added this to the 0.9.10 milestone Dec 8, 2014

@sithhell sithhell added ready and removed ready labels Jan 7, 2015

hkaiser added a commit that referenced this issue Feb 26, 2015

@hkaiser hkaiser self-assigned this Feb 26, 2015

@hkaiser hkaiser referenced this issue Feb 26, 2015

Merged

Fixing 1325 #1384

@sithhell

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2015

hmm, what if there are no more calls into the parcel handler after a erronous apply? I think the default should be to call terminate there as well.

@hkaiser

This comment has been minimized.

Copy link
Member

commented Feb 26, 2015

Huh? I removed storing exceptions and call terminate by default now (see #1384)

@sithhell

This comment has been minimized.

Copy link
Member Author

commented Feb 26, 2015

Ok, I am confused as the ticket says that apply should do nothing by default ... after looking throught the code of the PR, my question is resolved.

@sithhell sithhell closed this Feb 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.