Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HPX does not build with Boost 1.58.0 #1527

Closed
eschnett opened this issue May 19, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@eschnett
Copy link
Contributor

commented May 19, 2015

I am trying to build HPX 0.9.10 with Boost 1.58.0. This is on OS X using clang 3.6.0. The build aborts with the error message

/Users/eschnett/software/boost-1.58.0/include/boost/serialization/vector.hpp:216:18: error: comparison of integers of different signs: 'int' and 'base_type' (aka 'unsigned long') [-Werror,-Wsign-compare]
    for(i = 0; i < count; ++i){
               ~ ^ ~~~~~

This looks as if Boost misbehaved, iterating over the element of std::vector using int (why???). HPX then adds -Werror to the mix, leading to this build failure.

It is customary to disable -Werror in released versions for this reason.

This problem sounds oddly familiar; was this discussed before?

@hkaiser

This comment has been minimized.

Copy link
Member

commented May 19, 2015

You reported that before (see #1475). As said, Boost V1.58 was not released at the point when we released HPX V0.9.10.

@hkaiser

This comment has been minimized.

Copy link
Member

commented May 23, 2015

Until the next release of HPX please patch your local copy of HPX by removing the -Werror flag locally (https://github.com/STEllAR-GROUP/hpx/blob/0.9.10/CMakeLists.txt#L818).

@hkaiser hkaiser closed this May 23, 2015

@hkaiser hkaiser added this to the 0.9.11 milestone May 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.