Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend inspect tool #1559

Closed
hkaiser opened this issue May 28, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@hkaiser
Copy link
Member

commented May 28, 2015

The inspect tool should be extended to detect violations of more coding guidelines and to ensure we use certain functionalities consistently. Here is a possible list of inspect checker to add:

  • line length shouldn't exceed 80 characters (soft limit), and 90 characters (hard limit) (#1683)
  • no trailing whitespace (#1583)
  • don't use boost::move, use std::move instead (#1603)
  • don't use std::begin/std::end as some compilers don't support it (yet), use boost::begin/boost::end instead (#1603)
  • spell check *.qbk and doxygen comments
  • Let generated filename/line information into link pointing to the line on the correct commit on github
  • don't use #include <hpx/hpx_fwd.hpp>

Also:

  • the generated report should have a clickable logo referring to the github repository of HPX (#1604)

@hkaiser hkaiser added this to the 0.9.11 milestone May 28, 2015

@hkaiser hkaiser modified the milestones: 0.9.11, 0.9.12 Nov 12, 2015

hkaiser added a commit that referenced this issue May 1, 2016

hkaiser added a commit that referenced this issue May 1, 2016

hkaiser added a commit that referenced this issue May 1, 2016

hkaiser added a commit that referenced this issue May 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.