Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpx project name is not HPX #1675

Closed
biddisco opened this issue Jul 21, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@biddisco
Copy link
Contributor

commented Jul 21, 2015

I have found that scripts for finding HPX in certain projects do not behave as expected.

The problem is caused by the fact that hpx declares itself as

    project(hpx C CXX)

and generates the file

    /lib/cmake/hpx/HPXConfig.cmake

which is correctly found by

    find_package(HPX)

but not by

    find_package(hpx)

which is created by scripts which assume the project name is hpx (as declared in the project cmakelists)
The find_package documentation states :

The command searches for a file called "<name>Config.cmake" or \
    "<lower-case-name>-config.cmake" for each name specified.

so we should either rename the project to HPX instead of hpx, or modify the gnerated config file to be hpxConfig.cmake. (but that means anyone using find_package(HPX) will have to change their cmake), so option 1 looks better.

@sithhell

This comment has been minimized.

Copy link
Member

commented Jul 21, 2015

Option 1 sounds sane, yes. Can you make that change?

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jul 21, 2015

I agree, let's go for option 1.

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jul 24, 2015

This was fixed by merging #1682

@hkaiser hkaiser closed this Jul 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.