Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timer counters for tfunc_total and exec_total #1688

Closed
pagrubel opened this issue Jul 25, 2015 · 8 comments

Comments

@pagrubel
Copy link
Member

commented Jul 25, 2015

This timers might be useful by themselves and are the factors used to compute idle rate

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jul 25, 2015

@pagrubel Any ideas how to call those counters?

@pagrubel

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2015

so tfunc is total execution time and exec_times the computation time
tfunc /threadss/time/functions exec/threads/time/function_computations

I don't know what do you think?

@pagrubel

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2015

While you are at it I still don't understand how that assert works correctly it seems it should be the opposite since tfunc_total should be larger than exec_total. tfunk includes overheads. Am I thinking wrong???

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jul 25, 2015

The assert is correct (see https://github.com/STEllAR-GROUP/hpx/blob/master/src/runtime/threads/detail/thread_pool.cpp#L758):

HPX_ASSERT(tfunc_time > exec_time);

it makes sure that tfunc_time is always larger than exec_time. One reason for this to fail would be for the two to be equal, but this is highly unlikely for any clock with reasonable resolution. Otherwise its a bug somewhere.

@biddisco

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2015

I pushed a ">=" fix for the case when the times are the same - which seems to happen to me, possibly because the counter has not yet registered any real 'work' when I query it on a new node.

@pagrubel

This comment has been minimized.

Copy link
Member Author

commented Jul 26, 2015

Guess i was thinking backwards about this

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jul 30, 2015

@pagrubel pls see #1694. This adds two new counters:

  • /threads/time/cumulative: returns the overall time spent executing HPX threads (exec_time)
  • /threads/time/cumulative-overheads: return overall time incurred by thread execution overheads (tfunc_time - exec_time)

@hkaiser hkaiser closed this in ee8cfdc Aug 7, 2015

hkaiser added a commit that referenced this issue Aug 7, 2015

Merge pull request #1694 from STEllAR-GROUP/fixing_1688
Fixed #1688: Add timer counters for tfunc_total and exec_total
@pagrubel

This comment has been minimized.

Copy link
Member Author

commented Aug 23, 2015

These counters should be in seconds since they are cumulative time for all threads

@pagrubel pagrubel reopened this Aug 23, 2015

@hkaiser hkaiser closed this in b6adc46 Aug 23, 2015

hkaiser added a commit that referenced this issue Aug 23, 2015

Merge pull request #1734 from STEllAR-GROUP/fixed_1688
Fixed #1688: Add timer counters for tfunc_total and exec_total

hkaiser added a commit that referenced this issue Aug 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.