Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting INTERFACE_COMPILE_OPTIONS for hpx_init in CMake taints Fortran_FLAGS #1973

Closed
gentryx opened this issue Jan 30, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@gentryx
Copy link
Member

commented Jan 30, 2016

When one adds hpx_init via target_link_libraries() to a target which includes a Fortran source file then compilation of the Fortran source will fail because "-std=c++14" is added to the Fortran compiler flags.

@hkaiser hkaiser added this to the 0.9.12 milestone Jan 30, 2016

@sithhell

This comment has been minimized.

Copy link
Member

commented Jan 31, 2016

Am 30.01.2016 10:38 nachm. schrieb "Andreas Schäfer" <
notifications@github.com>:

When one adds hpx_init via target_link_libraries() to a target which includes a Fortran source file then compilation of the Fortran source will fail because "-std=c++14" is added to the Fortran compiler flags.

Why do you need to link Fortran sources against libhpx_init/libhpx?


Reply to this email directly or view it on GitHub.

@sithhell

This comment has been minimized.

Copy link
Member

commented Jan 31, 2016

Could you post the target property LINKER_LANGUAGE for your library target
please? We might be able to do something there...
Am 31.01.2016 9:52 vorm. schrieb "Thomas Heller" thom.heller@gmail.com:

Am 30.01.2016 10:38 nachm. schrieb "Andreas Schäfer" <
notifications@github.com>:

When one adds hpx_init via target_link_libraries() to a target which
includes a Fortran source file then compilation of the Fortran source will
fail because "-std=c++14" is added to the Fortran compiler flags.

Why do you need to link Fortran sources against libhpx_init/libhpx?


Reply to this email directly or view it on GitHub.

@gentryx

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2016

  • I have an executable where the C++ code needs to link against both, HPX and a Fortran kernel
  • the LINKER_LANGUAGE property of the executable's CMake target is undefined
  • I only get this error with gfortran 4.8.5. gfortran 4.9.3 succeeds (throws a warning instead of an error).
  • Since I now have a workaround, you could close this ticket. I still feel it's a bug that ought to be fixed.

@sithhell sithhell modified the milestones: 0.9.99, 1.0.0 Jul 15, 2016

@hkaiser

This comment has been minimized.

Copy link
Member

commented Oct 23, 2016

@gentryx How would you propose to fix this issue? Could you create a small reproducing use case for us to try, please?

@hkaiser

This comment has been minimized.

Copy link
Member

commented Mar 21, 2017

I'll go ahead and close this. Please feel free to reopen if the issue starts blocking you again.

@hkaiser hkaiser closed this Mar 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.