New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming inconsistency in parallel algorithms. #2700

Closed
taeguk opened this Issue Jun 17, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@taeguk
Member

taeguk commented Jun 17, 2017

There are naming inconsistencies in parallel algorithms.

F vs Pred

F -

template <typename ExPolicy, typename InIter, typename OutIter, typename F,

Pred -
template <typename InIter, typename OutIter, typename Pred, typename Proj>

My opinion - In many places, two namings are mixed and used. It seems better to using Pred consistently.

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jun 17, 2017

Member

I'd be glad to accept a corresponding PR

Member

hkaiser commented Jun 17, 2017

I'd be glad to accept a corresponding PR

@taeguk

This comment has been minimized.

Show comment
Hide comment
@taeguk

taeguk Jun 17, 2017

Member

@hkaiser Okay, I'll do that in July.

Member

taeguk commented Jun 17, 2017

@hkaiser Okay, I'll do that in July.

@taeguk

This comment has been minimized.

Show comment
Hide comment
@taeguk

taeguk Jul 2, 2017

Member

@hkaiser I have more confusions about naming.
RandomIt vs RanIter vs RandIter
ForwardIt vs FwdIter
Compare vs Comp

Even though this is trivial thing, it seems better that there is one consistent naming.
How do you think about it?

Member

taeguk commented Jul 2, 2017

@hkaiser I have more confusions about naming.
RandomIt vs RanIter vs RandIter
ForwardIt vs FwdIter
Compare vs Comp

Even though this is trivial thing, it seems better that there is one consistent naming.
How do you think about it?

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 2, 2017

Member

Even though this is trivial thing, it seems better that there is one consistent naming.
How do you think about it?

By all means, go for it. Thanks!

Member

hkaiser commented Jul 2, 2017

Even though this is trivial thing, it seems better that there is one consistent naming.
How do you think about it?

By all means, go for it. Thanks!

@taeguk

This comment has been minimized.

Show comment
Hide comment
@taeguk

taeguk Jul 2, 2017

Member

Which naming is better as you think?
RandomIt vs RandIter
Compare vs Comp

Member

taeguk commented Jul 2, 2017

Which naming is better as you think?
RandomIt vs RandIter
Compare vs Comp

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 2, 2017

Member

Which naming is better as you think?

FWIW, we've mostly been using InIter, FwdIter, BidirIter, RanIter, OutIter, and Comp. In other places we've used Op or Pred. In the end it doesn't matter as long as it is consistent.

Member

hkaiser commented Jul 2, 2017

Which naming is better as you think?

FWIW, we've mostly been using InIter, FwdIter, BidirIter, RanIter, OutIter, and Comp. In other places we've used Op or Pred. In the end it doesn't matter as long as it is consistent.

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Oct 12, 2017

Member

I think we can close this now. Feel free to reopen if there are still places where the names are inconsistent.

Member

hkaiser commented Oct 12, 2017

I think we can close this now. Feel free to reopen if there are still places where the names are inconsistent.

@hkaiser hkaiser closed this Oct 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment