Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedulers that don't support suspend/resume are unusable #3180

Closed
hkaiser opened this issue Feb 17, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@hkaiser
Copy link
Member

commented Feb 17, 2018

All schedulers that don't support suspend/resume are currently not usable as the related functions are called from the resource partitioner unconditionally during startup, causing asserts to be fired.

@hkaiser hkaiser added this to the 1.1.0 milestone Feb 17, 2018

hkaiser added a commit that referenced this issue Feb 18, 2018

Making sure resume/suspend is not called for schedulers that don't su…
…pport it

- this introduces a new scheduler mode flag: enable_suspension that is set by default
  for the schedulers that support this operation
- this flag is also used to reject resume/suspend requests if this flag is not set
  for a given scheduler
- flyby: made scheduler_base::suspend()/resume() virtual

This fixes #3180
@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Feb 18, 2018

@msimberg I added a possible patch for this to #3179 (I need it for FLeCSI anyways). Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.