Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more versatile environmental/cmake variable support to hpx_find_* CMake macros #345

Closed
brycelelbach opened this issue Jul 10, 2012 · 1 comment

Comments

Projects
None yet
3 participants
@brycelelbach
Copy link
Member

commented Jul 10, 2012

[reported by blelbach] [Trac time Tue Feb 28 22:20:42 2012] * hpx_find_* macros should have a parameter specifying what prefixes to check for CMake detection variables (*_USE_SYSTEM, *_ROOT, etc). For example, for the HDF5 C++ library (HDF5_CPP), we want to check HDF5_USE_SYSTEM and HDF5_CPP_USE_SYSTEM (with the latter overriding the former).

  • hpx_find_* macros should have a parameter specifying what environmental variables to check for roots to use. For example, for Boost (BOOST), we want to check BOOST and BOOST_ROOT (with the latter overriding the former).

For both of the above parameters, the standard names (e.g. ${name}_ROOT, ${name}_USE_SYSTEM) should override the specified parameters.

@sithhell

This comment has been minimized.

Copy link
Member

commented Sep 3, 2014

I think having hpx_find macros was a bad idea to begin with. With ecdb034 most of them have been removed and replace with find scripts following the cmake conventions. In addition they don't depend on HPX specific macros anymore so they can be pushed upstream eventually.
Closing this as "won't fix"

@sithhell sithhell closed this Sep 3, 2014

@hkaiser hkaiser modified the milestones: 0.9.10, 1.0.0 Feb 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.