Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge openSUSE reproducible patch #3575

Closed
junghans opened this issue Dec 4, 2018 · 16 comments

Comments

Projects
None yet
5 participants
@junghans
Copy link
Contributor

commented Dec 4, 2018

@hkaiser

This comment has been minimized.

Copy link
Member

commented Dec 6, 2018

@diehlpk would you be able to take care of this?

@hkaiser hkaiser added this to the 1.3.0 milestone Dec 6, 2018

@diehlpk

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@hkaiser Yes

@bmwiedemann

This comment has been minimized.

Copy link

commented Dec 7, 2018

btw, there is also similar detection for rdtsc but it is available on all CPUs since the first Pentiums (~25y), so I think the cmake logic can be simplified by assuming it is always there.

Oh and it is "openSUSE" - nearly everyone gets the caps wrong.

@junghans junghans changed the title Merge OpenSuse reproducible patch Merge openSUSE reproducible patch Dec 7, 2018

@junghans

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

@diehlpk, do have an account on https://build.opensuse.org/, there are more requests coming in: https://build.opensuse.org/request/show/655994

@diehlpk

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@junghans No, but sure I can create one.

@junghans

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

@diehlpk go ahead an let me know your username.

@diehlpk

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@junghans my username is diehlpk

diehlpk added a commit to diehlpk/hpx that referenced this issue Dec 7, 2018

@diehlpk

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

We have the option HPX_WITH_BUILD_DISTRIBUTION, which disables the check for rdtscp. This option needs to be to turned on for future releases of HPX packages, e.g. rpm or deb.

@sithhell

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

I'm not a fan of merging this particular patch. While I see the issue with cross compilation, rdtscd should just be turned of when building the rpms. Using rdtscd is an optimization, which we shouldn't just throw away.

@junghans

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

@diehlpk

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

@sithhell This is what we exactlt intent do do, just do not use rdtscp when building deb or rpm packages of hpx.

@diehlpk

This comment has been minimized.

Copy link
Member

commented Dec 7, 2018

Huh, https://build.opensuse.org/user/show/diehlpk isn't working yet...

it might take some time until my account is activated. I could login and verify my e-mail address at least.

@junghans

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2018

@diehlpk

This comment has been minimized.

Copy link
Member

commented Dec 8, 2018

Can you branch https://build.opensuse.org/package/show/science:HPC/hpx?

Yes, Could log in and home:diehlpk:branches:science:HPC > hpx

@junghans

This comment has been minimized.

Copy link
Contributor Author

commented Dec 8, 2018

On science:HPC/hpx: Added user diehlpk with role maintainer

@bmwiedemann

This comment has been minimized.

Copy link

commented Dec 8, 2018

@sithhell when I played with rdtsc, it was a lot faster than rdtscp (because it does not drain the execution pipeline), so I wonder where the optimization is. Maybe the added cpuid instruction takes some time and also drains the pipeline... but then how often do you call the timestamp / tick_counter / scheduling_loop functions?

diehlpk added a commit to diehlpk/hpx that referenced this issue Dec 10, 2018

diehlpk added a commit to diehlpk/hpx that referenced this issue Dec 13, 2018

diehlpk added a commit to diehlpk/hpx that referenced this issue Dec 13, 2018

msimberg added a commit that referenced this issue Dec 19, 2018

Merge pull request #3585 from diehlpk/openSUSEpatch
Extend Cmake for building hpx as distribution packages (refs #3575)

diehlpk added a commit to diehlpk/hpx that referenced this issue Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.