Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error when configuring with HPX_HAVE_ALGORITHM_INPUT_ITERATOR_SUPPORT=ON #3578

Closed
david8dixon opened this issue Dec 5, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@david8dixon
Copy link

commented Dec 5, 2018

Note to developers

Before I get started, I just want to say that you provide an impressive build system.

cmake -D CMAKE_BUILD_TYPE=Release -D CMAKE_INSTALL_PREFIX=path ..
make install -j4 

and in my build system find_package(HPX) just worked out of the box!

Expected Behavior

A successful build

Actual Behavior

/hpx/hpx/parallel/algorithms/merge.hpp fails to build, but I haven't gotten past resolving the errors in this file so there could be more. The first error I saw was an extra trailing || on line 850 of the aforementioned merge.hpp

Steps to Reproduce the Problem

1 .

cmake -D CMAKE_BUILD_TYPE=Release \
            -D CMAKE_INSTALL_PREFIX=path \ 
            -D HPX_HAVE_ALGORITHM_INPUT_ITERATOR_SUPPORT=ON ..
  1. make -j

Specifications

  • HPX Version: 1.3.0 (cloned it last week)
  • mac osx 10.12.6 with brew installation of llvm/6.0.1 and cmake/3.11.1

@hkaiser hkaiser added this to the 1.3.0 milestone Dec 5, 2018

@hkaiser

This comment has been minimized.

Copy link
Member

commented Dec 5, 2018

FWIW, the problem is here: https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/parallel/algorithms/merge.hpp#L850

@david8dixon thanks for reporting. We'll fix this asap.

@msimberg

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2018

@david8dixon I just want to point out that while we will fix the error you might not want to rely on HPX_HAVE_ALGORITHM_INPUT_ITERATOR_SUPPORT because we've deprecated it will remove it 6-12 months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.