Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make the python executable configurable through cmake #3718

Closed
yurivict opened this issue Feb 24, 2019 · 11 comments

Comments

@yurivict
Copy link

commented Feb 24, 2019

On FreeBSD several versions of python can be installed at the same time, with different executable names.

@hkaiser

This comment has been minimized.

Copy link
Member

commented Feb 24, 2019

@yurivict In general, HPX does not require any specific python executable to be built. We only install a python script hpx_run.py that can be helpful for running HPX applications. This script should be compatible with any Python version, so I don't think we need to make the Python executable configurable as this script will be used by the user in the end.

@yurivict

This comment has been minimized.

Copy link
Author

commented Feb 24, 2019

But you embed a specific executable name python, and this fails.

@hkaiser

This comment has been minimized.

Copy link
Member

commented Feb 24, 2019

@yurivict Fair enough.

@msimberg

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

I think we have some old Python 2-style print statements hanging around, but otherwise nothing that would still require Python 2 (AFAIK). This should be a straightforward change if someone feels like having a go at this. And I don't think we need to support Python 2 anymore. It's time to let it go...

@hkaiser

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

@msimberg it shouldn't be a problem to change the code such it is compatible with any Python version.

@diehlpk

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

@hkaiser @msimberg pr #3761 provides the changes such that our scripts run with python3 on Fedora 29.

@hkaiser hkaiser added this to the 1.3.0 milestone Apr 2, 2019

@hkaiser

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Can we close this now (#3761 was merged)?

@msimberg

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

The question is: is there a need for the user to actually change the python executable, or is it enough that it works with both Python 2 and 3 and the user doesn't care which? @yurivict I'm guessing in your case it was actually the latter, and not that you necessarily need to be able to set the Python executable?

@yurivict

This comment has been minimized.

Copy link
Author

commented Apr 23, 2019

is there a need for the user to actually change the python executable

The package should always work with a specific version of the python executable. Reasons: 1. predictability 2. you might not be able to guess what the executable is. 3. Package should have a run-time dependency on a particular python version, and if you pick a different one during build it will break during run because it would be missing.

This is why there should be a configuration variable for it.

@msimberg

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

@yurivict does #3803 do what you had in mind?

@msimberg

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@yurivict I'm closing this now that #3803 has been merged. Please reopen if needed.

@msimberg msimberg closed this Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.