New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a compilation sanity test #461

Closed
brycelelbach opened this Issue Jul 23, 2012 · 6 comments

Comments

Projects
None yet
3 participants
@brycelelbach
Member

brycelelbach commented Jul 23, 2012

ATM, if someone tries to use a broken compiler/broken boost install with HPX, the gcc version test is usually the place where this failure is first reported. A test that explicitly checks for a working compiler needs to be added before the gcc version test.

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 23, 2012

Member

Isn't that something cmake is already doing?

Member

hkaiser commented Jul 23, 2012

Isn't that something cmake is already doing?

@ghost ghost assigned brycelelbach Jul 23, 2012

@brycelelbach

This comment has been minimized.

Show comment
Hide comment
@brycelelbach

brycelelbach Jul 23, 2012

Member

Not properly, else we'd never see this problem

Member

brycelelbach commented Jul 23, 2012

Not properly, else we'd never see this problem

@sithhell

This comment has been minimized.

Show comment
Hide comment
@sithhell

sithhell Aug 14, 2012

Member

If the compiler is not able to produce binaries, cmake already detects this. What else are you trying to detect?

Member

sithhell commented Aug 14, 2012

If the compiler is not able to produce binaries, cmake already detects this. What else are you trying to detect?

@brycelelbach

This comment has been minimized.

Show comment
Hide comment
@brycelelbach

brycelelbach Aug 14, 2012

Member

Cmake doesnt test that the compiled binaries work (e.g. no runtime link errors)

On Aug 14, 2012, at 6:27 AM, Thomas Heller notifications@github.com wrote:

If the compiler is not able to produce binaries, cmake already detects this. What else are you trying to detect?


Reply to this email directly or view it on GitHub.

Member

brycelelbach commented Aug 14, 2012

Cmake doesnt test that the compiled binaries work (e.g. no runtime link errors)

On Aug 14, 2012, at 6:27 AM, Thomas Heller notifications@github.com wrote:

If the compiler is not able to produce binaries, cmake already detects this. What else are you trying to detect?


Reply to this email directly or view it on GitHub.

@sithhell

This comment has been minimized.

Show comment
Hide comment
@sithhell

sithhell Nov 22, 2012

Member

Nod. This might not work on all platforms though, consider cross compilation, where you can't execute the binary on the host (aka where cmake runs).

Member

sithhell commented Nov 22, 2012

Nod. This might not work on all platforms though, consider cross compilation, where you can't execute the binary on the host (aka where cmake runs).

@sithhell

This comment has been minimized.

Show comment
Hide comment
@sithhell

sithhell Jun 12, 2014

Member

I think we can close this ticket. CMake is actually checking if the compiled binary is working if not in cross compilation mode. If in doubt, people can always run make test

Member

sithhell commented Jun 12, 2014

I think we can close this ticket. CMake is actually checking if the compiled binary is working if not in cross compilation mode. If in doubt, people can always run make test

@sithhell sithhell closed this Jun 12, 2014

@hkaiser hkaiser modified the milestones: 0.9.9, 1.0.0 Jun 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment