Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disentangle segmented algorithms #5156

Closed
hkaiser opened this issue Feb 9, 2021 · 2 comments
Closed

Disentangle segmented algorithms #5156

hkaiser opened this issue Feb 9, 2021 · 2 comments

Comments

@hkaiser
Copy link
Member

hkaiser commented Feb 9, 2021

Currently the segmented algorithms are part and parcel of the implementation of the parallel algorithms. That unnecessarily complicates those. Now, that we have converted the parallel algorithm APIs into customization point (CPO) based implementations, the segmented algorithms could be separated and exposed through their own specializations of tag_invoke to be picked up by the CPOs. This would significantly simplify the base algorithms and allow to separate the segmented algorithms completely.

@hkaiser
Copy link
Member Author

hkaiser commented Feb 15, 2021

Here is a list of algorithms that need to be touched:

bors bot pushed a commit that referenced this issue Nov 15, 2021
5241: Adapt min_element, max_element and minmax_element to C++20 r=msimberg a=Jedi18

Adapts min_element, max_element and minmax_element to C++20.
Adds min_max_result result type
Add segmented algorithm tests for min_element, max_element and minmax_element

## Any background context you want to provide?
#4822
#5156

Co-authored-by: Hartmut Kaiser <hartmut.kaiser@gmail.com>
@hkaiser
Copy link
Member Author

hkaiser commented Nov 15, 2021

This can be closed now. Thanks to everybody helping with resolving the issue.

@hkaiser hkaiser closed this as completed Nov 15, 2021
Standard Algorithms automation moved this from Open Tickets to Merged to master Nov 15, 2021
Local/distributed split automation moved this from To do to Done Nov 15, 2021
@hkaiser hkaiser added this to the 1.8.0 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Standard Algorithms
  
Merged to master
Development

No branches or pull requests

1 participant