Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AGAS reference counting #72

Closed
brycelelbach opened this issue Jul 10, 2012 · 7 comments

Comments

Projects
None yet
1 participant
@brycelelbach
Copy link
Member

commented Jul 10, 2012

[reported by blelbach] [Trac time Sun Aug 14 21:52:21 2011] AGAS reference counting currently does not work correctly. This is a meta-bug for reference-counting related issues.

@brycelelbach

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2012

[comment by hkaiser] [Trac time Sun Aug 14 21:58:56 2011] How to reproduce:
a) add print statements to the constructor and destructor in 'hpx/examples/throttle/throttle/server/throttle.hpp'
b) run: spin -t2
c) run: throttle_client -x127.0.0.1:7911 -a127.0.0.1:7910
the spin application will print that a throttle component was created
d) run: thrpottle_client -x127.0.0.1:7911 -a127.0.0.1:7910 --release
the spin application will not print that the throttle component was released, but it should do so.

@brycelelbach

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2012

[comment by blelbach] [Trac time Sun Aug 14 22:02:59 2011] Moving this up to 0.7.0.

@brycelelbach

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2012

[comment by hkaiser] [Trac time Sun Aug 21 22:43:37 2011] One of things definitely broken is the queryid API function, which should return the registered gid for a given symbolic name. The returned gid needs to carry part of the global credit allowing the object to stay alive as long as the remote (requesting) client holds on to the gid.

I'm not sure whether registerid is broken in this respect as well, as it needs to increment the global reference count on behalf of the AGAS server itself, keeping the object alive even if the client calling registerid does not hold on to any references. Likewise, the unregisterid API needs to release the global reference count aquired by registerid. This will have to possibly free the object (if the reference count drops to zero).

@brycelelbach

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2012

[comment by hkaiser] [Trac time Sun Sep 18 15:58:42 2011] Use cases are described in #126

@brycelelbach

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2012

[comment by blelbach] [Trac time Mon Sep 26 00:03:08 2011] (In #58) 8e186d2.

@brycelelbach

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2012

[comment by hkaiser] [Trac time Fri Feb 17 12:13:38 2012] I disagree, this has to be fix asap and not somewhere in the future. Moving it back to 0.8

@brycelelbach

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2012

[comment by blelbach] [Trac time Thu Feb 23 01:38:04 2012] Closed, finally!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.