Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify util::tuple #838

Closed
K-ballo opened this issue Sep 8, 2013 · 2 comments

Comments

Projects
None yet
1 participant
@K-ballo
Copy link
Member

commented Sep 8, 2013

Our implementation of tuple is overly complex. It should be simplified.

@ghost ghost assigned K-ballo Sep 8, 2013

K-ballo added a commit that referenced this issue Sep 9, 2013

Simplify tuple.
See #838

Signed-off-by: K-ballo <k@fusionfenix.com>
@K-ballo

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2013

Tomas Heller pointed out that the numbered tuples were helping reduce compilation time. We have to measure and see if there is a noticeable impact.

@K-ballo

This comment has been minimized.

Copy link
Member Author

commented Sep 10, 2013

Tomas Heller reports no noticeable different with GCC 4.6:

Time it took without tupleN overloads:
real 4m7.254s
user 51m19.996s
sys 2m22.036s

Time it took with tupleN overloads:
real 4m8.285s
user 51m25.944s
sys 2m20.232s

@K-ballo K-ballo closed this Sep 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.