Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kill_process_tree (in process.py) more robust on Mac OS X #924

Closed
brycelelbach opened this issue Oct 5, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@brycelelbach
Copy link
Member

commented Oct 5, 2013

It should be possible to make the kill_process_tree code more effective for OS X using the same strategy that we use on linux (which basically amounts to recursively calling some invocation of ps - crude, but the best solution for finding a sub-tree of a process group). The only difference is that the OS X version of ps takes a slightly different syntax.

@ghost ghost assigned brycelelbach Oct 5, 2013

@brycelelbach

This comment has been minimized.

Copy link
Member Author

commented Oct 5, 2013

Done

@hkaiser

This comment has been minimized.

@hkaiser hkaiser reopened this Oct 14, 2013

@sithhell

This comment has been minimized.

@sithhell sithhell reopened this Oct 24, 2013

@brycelelbach

This comment has been minimized.

Copy link
Member Author

commented Oct 25, 2013

I just retested the kill process code, it's fine. The real problem is the way the buildbot is configured: it runs both builders (release and debug) on the mac buildslave at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.