New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking future unwrapping #1184

Merged
merged 6 commits into from Jul 11, 2014

Conversation

Projects
None yet
2 participants
@K-ballo
Member

K-ballo commented Jul 8, 2014

This PR adjusts our implementation to the latest draft of the Concurrency TS. It includes the following breaking changes:

  • future::unwrap and shared_future::unwrap were removed. The functionality is still present via the futures implicit unwrapping constructors (the one for shared_future is our own extension).
  • future::then and shared_future::then perform implicit unwrapping only for the future<R> case (previously, all kinds of futures).

Additionally, this PR also includes an optimization that was previously reverted due to failures caused by "too much implicit unwrapping" #588.

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 8, 2014

Member

I'm fine with merging this

Member

hkaiser commented Jul 8, 2014

I'm fine with merging this

@hkaiser hkaiser added this to the 0.9.9 milestone Jul 8, 2014

K-ballo added a commit that referenced this pull request Jul 11, 2014

@K-ballo K-ballo merged commit 16b16bb into master Jul 11, 2014

1 check failed

default Merged build finished.
Details

@K-ballo K-ballo deleted the unwrap branch Jul 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment