New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N4071 additional algorithms implemented #1206

Merged
merged 81 commits into from Aug 1, 2014

Conversation

Projects
None yet
6 participants
@Syntaf
Member

Syntaf commented Jul 29, 2014

A number of new algorithms have been implemented in N3960, and should be ready to merge into master. These include:

  • find
  • find_if
  • find_if_not
  • find_end
  • generate
  • generate_n
  • mismatch

Internal changes were made to the structure of the partition as well.

hkaiser and others added some commits Jul 13, 2014

Starting to implement parallel::mismatch
Conflicts:
	hpx/parallel/detail/all_any_none.hpp
More parallel::mismatch, adding new files
Conflicts:
	hpx/parallel/detail/reduce.hpp
Merge branch 'parallel_mismatch' of github.com:STEllAR-GROUP/hpx into…
… parallel_mismatch

Conflicts:
	hpx/include/parallel_mismatch.hpp
	hpx/parallel/detail/all_any_none.hpp
	hpx/parallel/detail/mismatch.hpp
	hpx/parallel/detail/reduce.hpp
	hpx/parallel/util/loop.hpp
Fixed typo causing failures for algorithms with task policy. Simplifi…
…ed return type handling by using async(sync, ...)
@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 23, 2014

Member

Why did you change this?

Member

hkaiser commented on ef21996 Jul 23, 2014

Why did you change this?

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 25, 2014

Member

This could be replaced by std::max_element.

Member

hkaiser commented on hpx/parallel/detail/find.hpp in 12c3df2 Jul 25, 2014

This could be replaced by std::max_element.

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 25, 2014

Member

Is it guaranteed to satisfy the requirements of a RandomAccessIterator?

Member

hkaiser commented on hpx/parallel/detail/find.hpp in 12c3df2 Jul 25, 2014

Is it guaranteed to satisfy the requirements of a RandomAccessIterator?

@hkaiser hkaiser added this to the 0.9.9 milestone Jul 29, 2014

@sithhell

This comment has been minimized.

Show comment
Hide comment
@sithhell

sithhell Jul 29, 2014

Member

Test this please

Member

sithhell commented Jul 29, 2014

Test this please

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 29, 2014

Member

looks ok to me

Member

hkaiser commented Jul 29, 2014

looks ok to me

@sithhell

This comment has been minimized.

Show comment
Hide comment
@sithhell

sithhell Jul 30, 2014

Member

ok to test

Member

sithhell commented Jul 30, 2014

ok to test

@sithhell

This comment has been minimized.

Show comment
Hide comment
@sithhell

sithhell Jul 30, 2014

Member

It's hard to tell what actually got changed due to the immense noise of other commits.

Member

sithhell commented Jul 30, 2014

It's hard to tell what actually got changed due to the immense noise of other commits.

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 30, 2014

Member

It's hard to tell what actually got changed due to the immense noise of other commits.

It exactly what the pull request comment says: this pull request adds the parallel versions of find, find_if, find_if_not, find_end, generate, generate_n, and mismatch.

Member

hkaiser commented Jul 30, 2014

It's hard to tell what actually got changed due to the immense noise of other commits.

It exactly what the pull request comment says: this pull request adds the parallel versions of find, find_if, find_if_not, find_end, generate, generate_n, and mismatch.

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Jul 30, 2014

Member

That's fixed now.

Member

hkaiser commented Jul 30, 2014

That's fixed now.

@sithhell

This comment has been minimized.

Show comment
Hide comment
@sithhell

sithhell Jul 30, 2014

Member

Hmm. Still failing sometimes.

Member

sithhell commented Jul 30, 2014

Hmm. Still failing sometimes.

@Syntaf Syntaf changed the title from N3960 additional algorithms implemented to N4071 additional algorithms implemented Jul 31, 2014

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Aug 1, 2014

Member

Everything looks ok now. Will merge.

Member

hkaiser commented Aug 1, 2014

Everything looks ok now. Will merge.

hkaiser added some commits Aug 1, 2014

Merge branch 'master' into n3960
Conflicts:
	hpx/lcos/local/recursive_mutex.hpp
	hpx/parallel/util/partitioner.hpp

hkaiser added a commit that referenced this pull request Aug 1, 2014

Merge pull request #1206 from STEllAR-GROUP/n3960
N4071 additional algorithms implemented

@hkaiser hkaiser merged commit bf9fff2 into master Aug 1, 2014

1 check failed

default Merged build finished.
Details

@hkaiser hkaiser deleted the n3960 branch Aug 1, 2014

@hkaiser hkaiser referenced this pull request Aug 2, 2014

Open

Implement N4409 on top of HPX #1141

40 of 41 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment