Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrono cleanup #1262

Merged
merged 8 commits into from Sep 17, 2014

Conversation

Projects
None yet
4 participants
@K-ballo
Copy link
Member

commented Sep 15, 2014

This PR tackles the conversion from posix_time based interfaces to chrono based interfaces. Existing functionality is retained (but posix_time support should be deprecated). See #1190.

@sithhell

This comment has been minimized.

Copy link
Member

commented Sep 16, 2014

Looks good so far!
How would support for std::chrono instead of boost::chrono look like?

@K-ballo

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2014

Support for std::chrono instead of boost::chrono would consist in replacing boost::chrono with std::chrono, plus a few includes.

Supporting both at the same would be even easier, requiring just a macro to detect if it's available, and an extra constructor for steady_time_point and steady_duration.

@zao

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2014

I mentioned it on IRC but it's probably good to persist here too.
Ubuntu 13.10 (or 13.04, memory is vague) had a libstdc++ in which some durations were 1000x as long as they should be. This means that you cannot universally replace Boost's Chrono with the standard one, even if the library claims to have one.

@hkaiser

This comment has been minimized.

Copy link
Member

commented Sep 16, 2014

Looks good to me, however having support for both, std::chrono and boost::chrono would be nice.

@K-ballo K-ballo force-pushed the chrono branch from fd29c90 to dc2bca7 Sep 16, 2014

@K-ballo

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2014

Added support for std::chrono.

@hkaiser hkaiser merged commit dc2bca7 into master Sep 17, 2014

@hkaiser hkaiser deleted the chrono branch Sep 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.