New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid CMake name clash for Boost.Thread library #1272

Merged
merged 1 commit into from Sep 23, 2014

Conversation

Projects
None yet
3 participants
@zao
Contributor

zao commented Sep 22, 2014

FindBoost uses Boost_THREAD_LIBRARY to denote the library filename to
link when using Boost.Thread.

HPX_SetupBoost.cmake used BOOST_THREAD_LIBRARY as the target to detect
the underlying platform threading library used by Boost.Thread. As
find_library avoids the search if the cache variable exists, this search
was always a no-op.

The temporary name is now instead BOOST_UNDERLYING_THREAD_LIBRARY.

Avoid CMake name clash for Boost.Thread library
FindBoost uses Boost_THREAD_LIBRARY to denote the library filename to
link when using Boost.Thread.

HPX_SetupBoost.cmake used BOOST_THREAD_LIBRARY as the target to detect
the underlying platform threading library used by Boost.Thread. As
find_library avoids the search if the cache variable exists, this search
was always a no-op.

The temporary name is now instead BOOST_UNDERLYING_THREAD_LIBRARY.

@hkaiser hkaiser added this to the 0.9.9 milestone Sep 22, 2014

sithhell added a commit that referenced this pull request Sep 23, 2014

Merge pull request #1272 from zao/detect_pthread_library
Avoid CMake name clash for Boost.Thread library

@sithhell sithhell merged commit 5b084be into STEllAR-GROUP:master Sep 23, 2014

@zao zao deleted the zao:detect_pthread_library branch Sep 23, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment