New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove merging map #1276

Merged
merged 4 commits into from Sep 28, 2014

Conversation

Projects
None yet
2 participants
@hkaiser
Member

hkaiser commented Sep 25, 2014

This patch removes util::merging_map in one of the places where it was used. That alone seems to fix some of our problems (see: http://hermione.cct.lsu.edu/builders/hpx_gcc_4_9_boost_1_56_debian_x86_64_debug/builds/59). More work needs to be done to remove all of the remaining uses of this class, but I think it's useful to merge this already.

@sithhell

This comment has been minimized.

Show comment
Hide comment
@sithhell

sithhell Sep 25, 2014

Member

Which remaining issues are you referring to?

Member

sithhell commented Sep 25, 2014

Which remaining issues are you referring to?

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser

hkaiser Sep 25, 2014

Member

I'm not sure - I simply don't trust this code in the primary_namespace server implementation. it's way too complex and Bryce's claims of its advantages are questionable.

Member

hkaiser commented Sep 25, 2014

I'm not sure - I simply don't trust this code in the primary_namespace server implementation. it's way too complex and Bryce's claims of its advantages are questionable.

@sithhell

This comment has been minimized.

Show comment
Hide comment
@sithhell

sithhell Sep 25, 2014

Member

I scheduled some builds. Let's see where we are.

Member

sithhell commented Sep 25, 2014

I scheduled some builds. Let's see where we are.

@hkaiser

This comment has been minimized.

Show comment
Hide comment
@hkaiser
Member

hkaiser commented Sep 26, 2014

sithhell added a commit that referenced this pull request Sep 28, 2014

@sithhell sithhell merged commit 7c48567 into master Sep 28, 2014

@sithhell sithhell deleted the remove_merging_map branch Sep 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment