Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions simplification #1350

Merged
merged 16 commits into from Jan 13, 2015

Conversation

Projects
None yet
4 participants
@K-ballo
Copy link
Member

commented Jan 11, 2015

Simplification of the actions implementation. As a result, the following macros were removed as HPX_DEFINE_COMPONENT_[DIRECT_]ACTION works for every case:

  • HPX_DEFINE_COMPONENT_CONST_ACTION
  • HPX_DEFINE_COMPONENT_ACTION_TPL
  • HPX_DEFINE_COMPONENT_CONST_ACTION_TPL
  • HPX_DEFINE_COMPONENT_CONST_DIRECT_ACTION
  • HPX_DEFINE_COMPONENT_DIRECT_ACTION_TPL
  • HPX_DEFINE_COMPONENT_CONST_DIRECT_ACTION_TPL
@hkaiser

This comment has been minimized.

Copy link
Member

commented Jan 11, 2015

This is very nice! LGTM. \o/

@pagrubel

This comment has been minimized.

Copy link
Member

commented Jan 12, 2015

Testing to see how this affects execution times for threading experiments.

@pagrubel

This comment has been minimized.

Copy link
Member

commented Jan 12, 2015

Still have errors when setting HPX_WITH_LOGGING=OFF for this branch (although it worked for master)

@@ -80,9 +80,9 @@ set(doxygen_dependencies
"${hpx_SOURCE_DIR}/hpx/parallel/algorithms/uninitialized_copy.hpp"
"${hpx_SOURCE_DIR}/hpx/parallel/algorithms/uninitialized_fill.hpp"
"${hpx_SOURCE_DIR}/hpx/runtime/get_ptr.hpp"
"${hpx_SOURCE_DIR}/hpx/runtime/actions/action_support.hpp"
"${hpx_SOURCE_DIR}/hpx/runtime/actions/basic_action.hpp"

This comment has been minimized.

Copy link
@sithhell

sithhell Jan 12, 2015

Member

isn't action_support.hpp still part of the headers? Why has it been removed here?

This comment has been minimized.

Copy link
@K-ballo

K-ballo Jan 12, 2015

Author Member

The bits from action_support.hpp that contribute to the documentation have been moved to basic_action.hpp about two commits ago.

@K-ballo

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2015

Still have errors when setting HPX_WITH_LOGGING=OFF for this branch (although it worked for master)

Works for me using gcc-4.9 and boost-1.56.0 (core works, some examples still fail to #include what they use on both branches). Which compiler and boost version are you using?

@sithhell

This comment has been minimized.

Copy link
Member

commented Jan 12, 2015

Looks pretty good to me! Thanks for this! Please announce the breaking changes on the ML!

@K-ballo K-ballo force-pushed the actions branch from 82101dc to 037aa69 Jan 12, 2015

hkaiser added a commit that referenced this pull request Jan 13, 2015

@hkaiser hkaiser merged commit d2d10a0 into master Jan 13, 2015

@hkaiser hkaiser deleted the actions branch Jan 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.