Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexicographical Compare completed #1354

Merged
merged 7 commits into from Jan 28, 2015

Conversation

Projects
None yet
2 participants
@Syntaf
Copy link
Member

commented Jan 19, 2015

The algorithm should be ready to merge, documentation and tests pass.

@hkaiser hkaiser added this to the 0.9.10 milestone Jan 20, 2015

@hkaiser hkaiser self-assigned this Jan 20, 2015

@@ -38,6 +38,15 @@ namespace hpx { namespace parallel { HPX_INLINE_NAMESPACE(v1) { namespace detail
}
};

///////////////////////////////////////////////////////////////////////////
struct less_than
{

This comment has been minimized.

Copy link
@hkaiser

hkaiser Jan 25, 2015

Member

Could we call this less<> instead (to be the same as std::less<>)?

boost::end(c),
[](){ throw std::runtime_error("test"); }),
boost::begin(h), boost::end(h));
f.get();

This comment has been minimized.

Copy link
@hkaiser

hkaiser Jan 25, 2015

Member

Please add a test that the algorithm actually returned before calling f.get() (see here for an example: https://github.com/STEllAR-GROUP/hpx/blob/master/tests/unit/parallel/copy.cpp#L202)

boost::end(c),
[](){ throw std::bad_alloc(); }),
boost::begin(h), boost::end(h));

This comment has been minimized.

Copy link
@hkaiser

hkaiser Jan 25, 2015

Member

Same as above, please add an additional test to verify that the algorithm itself didn't throw.

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jan 25, 2015

Please add the new algorithm to the documentation build system. This involves two steps:

@hkaiser hkaiser referenced this pull request Jan 25, 2015

Open

Implement N4409 on top of HPX #1141

40 of 42 tasks complete
@hkaiser

This comment has been minimized.

Copy link
Member

commented Jan 26, 2015

LGTM. Let's merge this.

hkaiser added a commit that referenced this pull request Jan 28, 2015

@hkaiser hkaiser merged commit 662e819 into master Jan 28, 2015

@hkaiser hkaiser deleted the lexicographical_compare branch Jan 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.