Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variadic templates support for runtime_support and components #1357

Merged
merged 6 commits into from Jan 23, 2015

Conversation

Projects
None yet
3 participants
@K-ballo
Copy link
Member

commented Jan 20, 2015

Variadic templates support for runtime_support and components.

@sithhell

This comment has been minimized.

Copy link
Member

commented Jan 22, 2015

Please readd the action_serialization_data constructors.

@sithhell

This comment has been minimized.

Copy link
Member

commented Jan 22, 2015

transfer_action is tuplyfied again.

@sithhell

This comment has been minimized.

Copy link
Member

commented Jan 22, 2015

I think the PR needs to be brought in line with latest master first.

@K-ballo K-ballo force-pushed the variadics branch from 852d6f0 to c6de86f Jan 22, 2015

@K-ballo

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2015

Rebased, with no conflicts. Running tests again.

@sithhell

This comment has been minimized.

Copy link
Member

commented Jan 22, 2015

functional::new_ is a little confusing. I was expecting it to call components::new_, not regular new. What do others think?

@sithhell

This comment has been minimized.

Copy link
Member

commented Jan 22, 2015

Looks good otherwise!

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jan 23, 2015

functional::new_ is a little confusing. I was expecting it to call components::new_, not
regular new. What do others think?

Letting it call the API instead of an internal function is the right thing to do, I believe.

@K-ballo K-ballo changed the title Variadics Variadic templates support for runtime_support and components Jan 23, 2015

K-ballo added a commit that referenced this pull request Jan 23, 2015

Merge pull request #1357 from STEllAR-GROUP/variadics
Variadic templates support for runtime_support and components

@K-ballo K-ballo merged commit d03039b into master Jan 23, 2015

@K-ballo K-ballo deleted the variadics branch Jan 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.