Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always stripping HPX command line arguments before executing start function #1443

Merged
merged 1 commit into from Apr 1, 2015

Conversation

Projects
None yet
3 participants
@hkaiser
Copy link
Member

commented Apr 1, 2015

This will fix #1437: hpx::init() should strip HPX-related flags from argv

@gentryx

This comment has been minimized.

Copy link
Member

commented Apr 1, 2015

Looks good to me, thanks!

std::string const& /*app_name*/, int argc, char** argv, hpx::runtime_mode mode)
inline int
init(util::function_nonser<int(int, char**)> const& f,
std::string const& /*app_name*/, int argc, char** argv,

This comment has been minimized.

Copy link
@sithhell

sithhell Apr 1, 2015

Member

Why is the app_name not passed here? If it isn't used anyway, can't we remove it?

This comment has been minimized.

Copy link
@hkaiser

hkaiser Apr 1, 2015

Author Member

Good point. It was of no use for the old code but can now be utilized. I'll add that. OTOH, removing it wouldn't do any harm either...

sithhell added a commit that referenced this pull request Apr 1, 2015

Merge pull request #1443 from STEllAR-GROUP/fixing_1437
Always stripping HPX command line arguments before executing start function

@sithhell sithhell merged commit d80a0e9 into master Apr 1, 2015

@sithhell sithhell deleted the fixing_1437 branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.