Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed container creation #1468

Merged
merged 7 commits into from Apr 23, 2015

Conversation

Projects
None yet
2 participants
@hkaiser
Copy link
Member

commented Apr 20, 2015

This patch corrects the containers (hpx::vector and hpx::unordered_map) to use the new distribution policies to allocate their partitions.

hkaiser added some commits Apr 20, 2015

return f.then(launch::sync,
[](hpx::future<std::vector<bulk_locality_result> > && f)
{
std::vector<hpx::id_type> result;

This comment has been minimized.

Copy link
@sithhell

sithhell Apr 22, 2015

Member

wouldn't it make sense to call reserve here?

{
HPX_ASSERT(localities_.size() == v.size());

std::vector<bulk_locality_result> result;

This comment has been minimized.

Copy link
@sithhell

sithhell Apr 22, 2015

Member

wouldn't it make sense to call reserve here?

{
HPX_ASSERT(localities_.size() == v.size());

std::vector<bulk_locality_result> result;

This comment has been minimized.

Copy link
@sithhell

sithhell Apr 22, 2015

Member

Another candidate for reserving the memory a priori

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2015

This also fixes #1309: hpx::vector partitions are not easily extendable by applications

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2015

@heller: I addressed your comments above

sithhell added a commit that referenced this pull request Apr 23, 2015

@sithhell sithhell merged commit 17863b1 into master Apr 23, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@sithhell sithhell deleted the fixed_container_creation branch Apr 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.