Adds a tool for inspect that checks for character limits #1683
Conversation
|
Would it be possible to except |
|
I suppose, let me work on it, and as long as that is the preferred result it could work. |
|
I think it would be a good idea to exclude these items:
I am also not a big fan of a strict 80 characters line limit. I'd rather prefer to escape this limit occasionally. It's sometimes odd to just break a line because you are a few characters over the limit. |
Agreed. We settled on a hard 90 character limit for now (with 80 characters being a 'soft' limit as before). The main incentive for this rule is to ensure readability in any contexts (i.e. in diff-views on github, etc.) |
Sure, that can be done. Even if I think that files under our control should be slowly fixed to conform to this rule as it simplifies online reading, etc. For external code inspect can be disabled by simply placing a file named |
|
Yeah, the name of the branch was made before we agreed on the limit, the actual limit is set upon launch, with the default being 90. Should I exempt links (https://...) from the limit? |
|
There seems to be a problem with giving circleci the option to choose the length of the limit, so for now it is going to be set at 90, only configurable in the inspect tool. Please let me know if you still want to prompt circleci to set the limit. |
@Bcorde5 Sorry, I don't understand what you mean by 'there seems to be a problem'. |
|
Disregard that last statement, I believe I have found a solution to the problem. |
Bcorde5
force-pushed
the
80_line_limit
branch
3 times, most recently
from
46c34da
to
07be225
Compare
|
I am going to make an exception for #define and #if right now, if this seems troublesome, please let me know soon. |
Created to default to hard limit of 90, excludes documented files, CMakeLists.txt, and #error.
Preprocessor directives have to be one a single line. However, you can use a single |
|
Now that I have the grasp of how to use , I can fix #define and #if, so only #error will be an exception, thank you. |
|
It has been decided that url links will be ignored by this check, as it would be too confusing if they were edited. |
also added an exception to urls
|
Does anyone know what is causing the error? |
|
@Bcorde5 just look at the circleci log here: https://circleci.com/gh/STEllAR-GROUP/hpx/1318 |
…ine_limit Conflicts: examples/1d_hydro/1d_hydro_upwind.cpp examples/transpose/transpose_block.cpp hpx/lcos/detail/full_empty_entry.hpp hpx/parallel/executors/service_executors.hpp hpx/runtime/threads/policies/static_priority_queue_scheduler.hpp hpx/runtime/threads/threadmanager.hpp src/hpx_init.cpp src/runtime/threads/executors/thread_pool_executors.cpp src/runtime_impl.cpp tests/performance/local/vector_foreach.cpp
…ine_limit Conflicts: hpx/runtime/serialization/array.hpp
…ine_limit Conflicts: hpx/plugins/parcel/coalescing_message_handler.hpp hpx/plugins/parcel/message_buffer.hpp hpx/runtime/parcelset/decode_parcels.hpp hpx/runtime/parcelset/parcel.hpp hpx/runtime/parcelset/parcelhandler.hpp hpx/runtime/parcelset/parcelport_impl.hpp plugins/parcelport/mpi/parcelport_mpi.cpp src/runtime_impl.cpp
Adds a tool for inspect that checks for character limits
|
Thanks! |
The first test is to see how circle tests handles the build, if successful, then I will fix the mistakes. Comments and criticisms are welcome.