Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace value_or_error with custom storage, unify future_data state #1689

Merged
merged 1 commit into from Jul 31, 2015

Conversation

Projects
None yet
2 participants
@K-ballo
Copy link
Member

commented Jul 27, 2015

This PR removes value_or_error, which does a lot more than what the shared state needs but not enough to be actually useful outside of it. Pieces of it were moved to implement a custom storage within future_data itself. The empty/full state is replaced with empty/value/exception.

Here's one run not hampered by io failures, test errors look unrelated (holding lock while suspending in parcelport):
http://hermione.cct.lsu.edu/builders/hpx_gcc_4_6_boost_1_49_debian_x86_64_debug/builds/496

@hkaiser

This comment has been minimized.

Copy link
Member

commented Jul 27, 2015

Here's one run not hampered by io failures, test errors look unrelated (holding lock while suspending in parcelport): http://hermione.cct.lsu.edu/builders/hpx_gcc_4_6_boost_1_49_debian_x86_64_debug/builds/496

Uhh, this needs more investigation. While the errors do not look like as if they were directly caused by your patch, it might have shifted timings which manifest this problem (I have never before seen these locking issues in the parcelport).

hkaiser added a commit that referenced this pull request Jul 31, 2015

Merge pull request #1689 from STEllAR-GROUP/kill-value-or-error
Replace value_or_error with custom storage, unify future_data state

@hkaiser hkaiser merged commit 781010f into master Jul 31, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@hkaiser hkaiser deleted the kill-value-or-error branch Jul 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.