Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making non-serializable classes non-serializable #1901

Merged
merged 4 commits into from Dec 10, 2015

Conversation

Projects
None yet
3 participants
@AntonBikineev
Copy link
Contributor

commented Dec 8, 2015

Fixing one point from #1898

@sithhell

This comment has been minimized.

Copy link
Member

commented Dec 9, 2015

A unit test that shows the failure to compile without a serialize member would be nice here.

@sithhell sithhell added this to the 0.9.12 milestone Dec 9, 2015

@hkaiser

This comment has been minimized.

Copy link
Member

commented Dec 9, 2015

LGTM, thanks a lot!

hkaiser added a commit that referenced this pull request Dec 10, 2015

Merge pull request #1901 from STEllAR-GROUP/fixing_1898_bikineevs_part
Making non-serializable classes non-serializable

@hkaiser hkaiser merged commit 425826d into master Dec 10, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@hkaiser hkaiser deleted the fixing_1898_bikineevs_part branch Dec 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.