Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing when_xxx and wait_xxx for MSVC12 #2047

Merged
merged 1 commit into from Mar 23, 2016

Conversation

Projects
None yet
3 participants
@hkaiser
Copy link
Member

commented Mar 22, 2016

No description provided.

@hkaiser hkaiser added this to the 0.9.12 milestone Mar 22, 2016

@sithhell

This comment has been minimized.

Copy link
Member

commented Mar 22, 2016

Is msvc having problems with std::enable_if?

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2016

Is msvc having problems with std::enable_if?

No we just have not consistently switched from boost::enable_if to std::enable_if. We should probably slowly phase out boost::enable_if, though.

@K-ballo

This comment has been minimized.

Copy link
Member

commented Mar 22, 2016

Is this due to lack of C++14 SFINAE-friendly std::iterator_traits?

@hkaiser

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2016

Is this due to lack of C++14 SFINAE-friendly std::iterator_traits

Partially yes, also because of lacking SFINAE on the defaulted function template argument.

@hkaiser hkaiser force-pushed the fixed_msvc12 branch from 71e2bdc to 1231f5f Mar 23, 2016

@sithhell

This comment has been minimized.

Copy link
Member

commented Mar 23, 2016

LGTM now!

@sithhell sithhell merged commit 031684b into master Mar 23, 2016

2 checks passed

STE||AR Bot/hpx-inspect Build done.
Details
ci/circleci Your tests passed on CircleCI!
Details

@sithhell sithhell deleted the fixed_msvc12 branch Mar 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.